Merge pull request #275 from getmaxun/iframe

feat: support `iframe` extraction
This commit is contained in:
Rohit
2025-01-05 00:34:48 +05:30
committed by GitHub
6 changed files with 1416 additions and 629 deletions

View File

@@ -189,6 +189,7 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
* @returns {Array.<Object.<string, string>>} * @returns {Array.<Object.<string, string>>}
*/ */
window.scrapeSchema = function(lists) { window.scrapeSchema = function(lists) {
// Utility functions remain the same
function omap(object, f, kf = (x) => x) { function omap(object, f, kf = (x) => x) {
return Object.fromEntries( return Object.fromEntries(
Object.entries(object) Object.entries(object)
@@ -204,39 +205,64 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
} }
function findAllElements(config) { function findAllElements(config) {
if (!config.shadow || !config.selector.includes('>>')) { // Regular DOM query if no special delimiters
if (!config.selector.includes('>>') && !config.selector.includes(':>>')) {
return Array.from(document.querySelectorAll(config.selector)); return Array.from(document.querySelectorAll(config.selector));
} }
// For shadow DOM, we'll get all possible combinations // Split by both types of delimiters
const parts = config.selector.split('>>').map(s => s.trim()); const parts = config.selector.split(/(?:>>|:>>)/).map(s => s.trim());
const delimiters = config.selector.match(/(?:>>|:>>)/g) || [];
let currentElements = [document]; let currentElements = [document];
for (let i = 0; i < parts.length; i++) { for (let i = 0; i < parts.length; i++) {
const part = parts[i]; const part = parts[i];
const nextElements = []; const nextElements = [];
const isLast = i === parts.length - 1;
const delimiter = delimiters[i] || '';
const isIframeTraversal = delimiter === ':>>';
for (const element of currentElements) { for (const element of currentElements) {
try {
let targets; let targets;
if (i === 0) { if (i === 0) {
// First selector is queried from document // First selector is queried from main document
targets = Array.from(element.querySelectorAll(part)) targets = Array.from(element.querySelectorAll(part))
.filter(el => { .filter(el => {
// Only include elements that either: if (isLast) return true;
// 1. Have an open shadow root // For iframe traversal, only include iframes
// 2. Don't need shadow root (last part of selector) if (isIframeTraversal) return el.tagName === 'IFRAME';
if (i === parts.length - 1) return true; // For shadow DOM traversal, only include elements with shadow root
const shadowRoot = el.shadowRoot; return el.shadowRoot && el.shadowRoot.mode === 'open';
return shadowRoot && shadowRoot.mode === 'open';
}); });
} else { } else {
// For subsequent selectors, only use elements with open shadow roots if (isIframeTraversal) {
// Handle iframe traversal
const iframeDocument = element.contentDocument || element.contentWindow?.document;
if (!iframeDocument) continue;
targets = Array.from(iframeDocument.querySelectorAll(part));
if (!isLast) {
targets = targets.filter(el => el.tagName === 'IFRAME');
}
} else {
// Handle shadow DOM traversal
const shadowRoot = element.shadowRoot; const shadowRoot = element.shadowRoot;
if (!shadowRoot || shadowRoot.mode !== 'open') continue; if (!shadowRoot || shadowRoot.mode !== 'open') continue;
targets = Array.from(shadowRoot.querySelectorAll(part)); targets = Array.from(shadowRoot.querySelectorAll(part));
if (!isLast) {
targets = targets.filter(el => el.shadowRoot && el.shadowRoot.mode === 'open');
} }
}
}
nextElements.push(...targets); nextElements.push(...targets);
} catch (error) {
console.warn('Cannot access content:', error);
continue;
}
} }
if (nextElements.length === 0) return []; if (nextElements.length === 0) return [];
@@ -246,17 +272,21 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
return currentElements; return currentElements;
} }
// Modified to handle iframe context for URL resolution
function getElementValue(element, attribute) { function getElementValue(element, attribute) {
if (!element) return null; if (!element) return null;
// Get the base URL for resolving relative URLs
const baseURL = element.ownerDocument?.location?.href || window.location.origin;
switch (attribute) { switch (attribute) {
case 'href': { case 'href': {
const relativeHref = element.getAttribute('href'); const relativeHref = element.getAttribute('href');
return relativeHref ? new URL(relativeHref, window.location.origin).href : null; return relativeHref ? new URL(relativeHref, baseURL).href : null;
} }
case 'src': { case 'src': {
const relativeSrc = element.getAttribute('src'); const relativeSrc = element.getAttribute('src');
return relativeSrc ? new URL(relativeSrc, window.location.origin).href : null; return relativeSrc ? new URL(relativeSrc, baseURL).href : null;
} }
case 'innerText': case 'innerText':
return element.innerText?.trim(); return element.innerText?.trim();
@@ -267,7 +297,7 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
} }
} }
// Get the seed key based on the maximum number of elements found // Rest of the functions remain largely the same
function getSeedKey(listObj) { function getSeedKey(listObj) {
const maxLength = Math.max(...Object.values( const maxLength = Math.max(...Object.values(
omap(listObj, (x) => findAllElements(x).length) omap(listObj, (x) => findAllElements(x).length)
@@ -282,7 +312,12 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
return elements.map((element) => { return elements.map((element) => {
let candidate = element; let candidate = element;
const isUniqueChild = (e) => elements const isUniqueChild = (e) => elements
.filter((elem) => e.parentNode?.contains(elem)) .filter((elem) => {
// Handle both iframe and shadow DOM boundaries
const sameContext = elem.getRootNode() === e.getRootNode() &&
elem.ownerDocument === e.ownerDocument;
return sameContext && e.parentNode?.contains(elem);
})
.length === 1; .length === 1;
while (candidate && isUniqueChild(candidate)) { while (candidate && isUniqueChild(candidate)) {
@@ -293,7 +328,6 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
}); });
} }
// First try the MBE approach
const seedName = getSeedKey(lists); const seedName = getSeedKey(lists);
const seedElements = findAllElements(lists[seedName]); const seedElements = findAllElements(lists[seedName]);
const MBEs = getMBEs(seedElements); const MBEs = getMBEs(seedElements);
@@ -347,32 +381,42 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
* @returns {Array.<Array.<Object>>} Array of arrays of scraped items, one sub-array per list * @returns {Array.<Array.<Object>>} Array of arrays of scraped items, one sub-array per list
*/ */
window.scrapeList = async function ({ listSelector, fields, limit = 10 }) { window.scrapeList = async function ({ listSelector, fields, limit = 10 }) {
// Shadow DOM query functions remain unchanged // Enhanced query function to handle both iframe and shadow DOM
const queryShadowDOM = (rootElement, selector) => { const queryElement = (rootElement, selector) => {
if (!selector.includes('>>')) { if (!selector.includes('>>') && !selector.includes(':>>')) {
return rootElement.querySelector(selector); return rootElement.querySelector(selector);
} }
const parts = selector.split('>>').map(part => part.trim()); const parts = selector.split(/(?:>>|:>>)/).map(part => part.trim());
let currentElement = rootElement; let currentElement = rootElement;
for (let i = 0; i < parts.length; i++) { for (let i = 0; i < parts.length; i++) {
if (!currentElement) return null; if (!currentElement) return null;
if (!currentElement.querySelector && !currentElement.shadowRoot) { // Handle iframe traversal
currentElement = document.querySelector(parts[i]); if (currentElement.tagName === 'IFRAME') {
try {
const iframeDoc = currentElement.contentDocument || currentElement.contentWindow.document;
currentElement = iframeDoc.querySelector(parts[i]);
continue; continue;
} catch (e) {
console.warn('Cannot access iframe content:', e);
return null;
}
} }
// Try regular DOM first
let nextElement = currentElement.querySelector(parts[i]); let nextElement = currentElement.querySelector(parts[i]);
// Try shadow DOM if not found
if (!nextElement && currentElement.shadowRoot) { if (!nextElement && currentElement.shadowRoot) {
nextElement = currentElement.shadowRoot.querySelector(parts[i]); nextElement = currentElement.shadowRoot.querySelector(parts[i]);
} }
// Check children's shadow roots if still not found
if (!nextElement) { if (!nextElement) {
const allChildren = Array.from(currentElement.children || []); const children = Array.from(currentElement.children || []);
for (const child of allChildren) { for (const child of children) {
if (child.shadowRoot) { if (child.shadowRoot) {
nextElement = child.shadowRoot.querySelector(parts[i]); nextElement = child.shadowRoot.querySelector(parts[i]);
if (nextElement) break; if (nextElement) break;
@@ -386,26 +430,40 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
return currentElement; return currentElement;
}; };
const queryShadowDOMAll = (rootElement, selector) => { // Enhanced query all function for both contexts
if (!selector.includes('>>')) { const queryElementAll = (rootElement, selector) => {
if (!selector.includes('>>') && !selector.includes(':>>')) {
return rootElement.querySelectorAll(selector); return rootElement.querySelectorAll(selector);
} }
const parts = selector.split('>>').map(part => part.trim()); const parts = selector.split(/(?:>>|:>>)/).map(part => part.trim());
let currentElements = [rootElement]; let currentElements = [rootElement];
for (const part of parts) { for (const part of parts) {
const nextElements = []; const nextElements = [];
for (const element of currentElements) { for (const element of currentElements) {
// Handle iframe traversal
if (element.tagName === 'IFRAME') {
try {
const iframeDoc = element.contentDocument || element.contentWindow.document;
nextElements.push(...iframeDoc.querySelectorAll(part));
} catch (e) {
console.warn('Cannot access iframe content:', e);
continue;
}
} else {
// Regular DOM elements
if (element.querySelectorAll) { if (element.querySelectorAll) {
nextElements.push(...element.querySelectorAll(part)); nextElements.push(...element.querySelectorAll(part));
} }
// Shadow DOM elements
if (element.shadowRoot) { if (element.shadowRoot) {
nextElements.push(...element.shadowRoot.querySelectorAll(part)); nextElements.push(...element.shadowRoot.querySelectorAll(part));
} }
// Check children's shadow roots
const children = Array.from(element.children || []); const children = Array.from(element.children || []);
for (const child of children) { for (const child of children) {
if (child.shadowRoot) { if (child.shadowRoot) {
@@ -413,6 +471,7 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
} }
} }
} }
}
currentElements = nextElements; currentElements = nextElements;
} }
@@ -420,14 +479,17 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
return currentElements; return currentElements;
}; };
// Enhanced table processing helper functions with shadow DOM support // Enhanced value extraction with context awareness
function extractValue(element, attribute) { function extractValue(element, attribute) {
if (!element) return null; if (!element) return null;
// Check for shadow root first // Get context-aware base URL
const baseURL = element.ownerDocument?.location?.href || window.location.origin;
// Check shadow root first
if (element.shadowRoot) { if (element.shadowRoot) {
const shadowContent = element.shadowRoot.textContent; const shadowContent = element.shadowRoot.textContent;
if (shadowContent && shadowContent.trim()) { if (shadowContent?.trim()) {
return shadowContent.trim(); return shadowContent.trim();
} }
} }
@@ -438,18 +500,19 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
return element.innerHTML.trim(); return element.innerHTML.trim();
} else if (attribute === 'src' || attribute === 'href') { } else if (attribute === 'src' || attribute === 'href') {
const attrValue = element.getAttribute(attribute); const attrValue = element.getAttribute(attribute);
return attrValue ? new URL(attrValue, window.location.origin).href : null; return attrValue ? new URL(attrValue, baseURL).href : null;
} }
return element.getAttribute(attribute); return element.getAttribute(attribute);
} }
// Enhanced table ancestor finding with context support
function findTableAncestor(element) { function findTableAncestor(element) {
let currentElement = element; let currentElement = element;
const MAX_DEPTH = 5; const MAX_DEPTH = 5;
let depth = 0; let depth = 0;
while (currentElement && depth < MAX_DEPTH) { while (currentElement && depth < MAX_DEPTH) {
// Check if current element is in shadow DOM // Handle shadow DOM
if (currentElement.getRootNode() instanceof ShadowRoot) { if (currentElement.getRootNode() instanceof ShadowRoot) {
currentElement = currentElement.getRootNode().host; currentElement = currentElement.getRootNode().host;
continue; continue;
@@ -460,51 +523,68 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
} else if (currentElement.tagName === 'TR') { } else if (currentElement.tagName === 'TR') {
return { type: 'TR', element: currentElement }; return { type: 'TR', element: currentElement };
} }
// Handle iframe crossing
if (currentElement.tagName === 'IFRAME') {
try {
currentElement = currentElement.contentDocument.body;
} catch (e) {
return null;
}
} else {
currentElement = currentElement.parentElement; currentElement = currentElement.parentElement;
}
depth++; depth++;
} }
return null; return null;
} }
// Helper function to get cell index
function getCellIndex(td) { function getCellIndex(td) {
let index = 0;
let sibling = td;
// Handle shadow DOM case
if (td.getRootNode() instanceof ShadowRoot) { if (td.getRootNode() instanceof ShadowRoot) {
const shadowRoot = td.getRootNode(); const shadowRoot = td.getRootNode();
const allCells = Array.from(shadowRoot.querySelectorAll('td')); const allCells = Array.from(shadowRoot.querySelectorAll('td'));
return allCells.indexOf(td); return allCells.indexOf(td);
} }
let index = 0;
let sibling = td;
while (sibling = sibling.previousElementSibling) { while (sibling = sibling.previousElementSibling) {
index++; index++;
} }
return index; return index;
} }
// Helper function to check for TH elements
function hasThElement(row, tableFields) { function hasThElement(row, tableFields) {
for (const [label, { selector }] of Object.entries(tableFields)) { for (const [_, { selector }] of Object.entries(tableFields)) {
const element = queryShadowDOM(row, selector); const element = queryElement(row, selector);
if (element) { if (element) {
let current = element; let current = element;
while (current && current !== row) { while (current && current !== row) {
// Check if we're in shadow DOM
if (current.getRootNode() instanceof ShadowRoot) { if (current.getRootNode() instanceof ShadowRoot) {
current = current.getRootNode().host; current = current.getRootNode().host;
continue; continue;
} }
if (current.tagName === 'TH') { if (current.tagName === 'TH') return true;
return true;
if (current.tagName === 'IFRAME') {
try {
current = current.contentDocument.body;
} catch (e) {
break;
} }
} else {
current = current.parentElement; current = current.parentElement;
} }
} }
} }
}
return false; return false;
} }
// Helper function to filter rows
function filterRowsBasedOnTag(rows, tableFields) { function filterRowsBasedOnTag(rows, tableFields) {
for (const row of rows) { for (const row of rows) {
if (hasThElement(row, tableFields)) { if (hasThElement(row, tableFields)) {
@@ -520,7 +600,7 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
}); });
} }
// Class similarity functions remain unchanged // Class similarity comparison functions
function calculateClassSimilarity(classList1, classList2) { function calculateClassSimilarity(classList1, classList2) {
const set1 = new Set(classList1); const set1 = new Set(classList1);
const set2 = new Set(classList2); const set2 = new Set(classList2);
@@ -529,11 +609,34 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
return intersection.size / union.size; return intersection.size / union.size;
} }
// Enhanced similar elements finding with context support
function findSimilarElements(baseElement, similarityThreshold = 0.7) { function findSimilarElements(baseElement, similarityThreshold = 0.7) {
const baseClasses = Array.from(baseElement.classList); const baseClasses = Array.from(baseElement.classList);
if (baseClasses.length === 0) return []; if (baseClasses.length === 0) return [];
const potentialElements = document.getElementsByTagName(baseElement.tagName);
return Array.from(potentialElements).filter(element => { const allElements = [];
// Get elements from main document
allElements.push(...document.getElementsByTagName(baseElement.tagName));
// Get elements from shadow DOM
if (baseElement.getRootNode() instanceof ShadowRoot) {
const shadowHost = baseElement.getRootNode().host;
allElements.push(...shadowHost.getElementsByTagName(baseElement.tagName));
}
// Get elements from iframes
const iframes = document.getElementsByTagName('iframe');
for (const iframe of iframes) {
try {
const iframeDoc = iframe.contentDocument || iframe.contentWindow.document;
allElements.push(...iframeDoc.getElementsByTagName(baseElement.tagName));
} catch (e) {
console.warn('Cannot access iframe content:', e);
}
}
return allElements.filter(element => {
if (element === baseElement) return false; if (element === baseElement) return false;
const similarity = calculateClassSimilarity( const similarity = calculateClassSimilarity(
baseClasses, baseClasses,
@@ -543,8 +646,8 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
}); });
} }
// Main scraping logic with shadow DOM support // Main scraping logic with context support
let containers = queryShadowDOMAll(document, listSelector); let containers = queryElementAll(document, listSelector);
containers = Array.from(containers); containers = Array.from(containers);
if (containers.length === 0) return []; if (containers.length === 0) return [];
@@ -569,7 +672,7 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
// Classify fields // Classify fields
containers.forEach((container, containerIndex) => { containers.forEach((container, containerIndex) => {
for (const [label, field] of Object.entries(fields)) { for (const [label, field] of Object.entries(fields)) {
const sampleElement = queryShadowDOM(container, field.selector); const sampleElement = queryElement(container, field.selector);
if (sampleElement) { if (sampleElement) {
const ancestor = findTableAncestor(sampleElement); const ancestor = findTableAncestor(sampleElement);
@@ -591,32 +694,55 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
const tableData = []; const tableData = [];
const nonTableData = []; const nonTableData = [];
// Process table data with shadow DOM support // Process table data with both iframe and shadow DOM support
for (let containerIndex = 0; containerIndex < containers.length; containerIndex++) { for (let containerIndex = 0; containerIndex < containers.length; containerIndex++) {
const container = containers[containerIndex]; const container = containers[containerIndex];
const { tableFields } = containerFields[containerIndex]; const { tableFields } = containerFields[containerIndex];
if (Object.keys(tableFields).length > 0) { if (Object.keys(tableFields).length > 0) {
const firstField = Object.values(tableFields)[0]; const firstField = Object.values(tableFields)[0];
const firstElement = queryShadowDOM(container, firstField.selector); const firstElement = queryElement(container, firstField.selector);
let tableContext = firstElement; let tableContext = firstElement;
// Find table context including shadow DOM // Find table context including both iframe and shadow DOM
while (tableContext && tableContext.tagName !== 'TABLE' && tableContext !== container) { while (tableContext && tableContext.tagName !== 'TABLE' && tableContext !== container) {
if (tableContext.getRootNode() instanceof ShadowRoot) { if (tableContext.getRootNode() instanceof ShadowRoot) {
tableContext = tableContext.getRootNode().host; tableContext = tableContext.getRootNode().host;
continue;
}
if (tableContext.tagName === 'IFRAME') {
try {
tableContext = tableContext.contentDocument.body;
} catch (e) {
break;
}
} else { } else {
tableContext = tableContext.parentElement; tableContext = tableContext.parentElement;
} }
} }
if (tableContext) { if (tableContext) {
// Get rows from both regular DOM and shadow DOM // Get rows from all contexts
const rows = []; const rows = [];
// Get rows from regular DOM
rows.push(...tableContext.getElementsByTagName('TR'));
// Get rows from shadow DOM
if (tableContext.shadowRoot) { if (tableContext.shadowRoot) {
rows.push(...tableContext.shadowRoot.getElementsByTagName('TR')); rows.push(...tableContext.shadowRoot.getElementsByTagName('TR'));
} }
rows.push(...tableContext.getElementsByTagName('TR'));
// Get rows from iframes
if (tableContext.tagName === 'IFRAME') {
try {
const iframeDoc = tableContext.contentDocument || tableContext.contentWindow.document;
rows.push(...iframeDoc.getElementsByTagName('TR'));
} catch (e) {
console.warn('Cannot access iframe rows:', e);
}
}
const processedRows = filterRowsBasedOnTag(rows, tableFields); const processedRows = filterRowsBasedOnTag(rows, tableFields);
@@ -628,6 +754,7 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
let element = null; let element = null;
if (cellIndex >= 0) { if (cellIndex >= 0) {
// Get TD element considering both contexts
let td = currentRow.children[cellIndex]; let td = currentRow.children[cellIndex];
// Check shadow DOM for td // Check shadow DOM for td
@@ -639,15 +766,15 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
} }
if (td) { if (td) {
element = queryShadowDOM(td, selector); element = queryElement(td, selector);
if (!element && selector.split(">").pop().includes('td:nth-child')) { if (!element && selector.split(/(?:>>|:>>)/).pop().includes('td:nth-child')) {
element = td; element = td;
} }
if (!element) { if (!element) {
const tagOnlySelector = selector.split('.')[0]; const tagOnlySelector = selector.split('.')[0];
element = queryShadowDOM(td, tagOnlySelector); element = queryElement(td, tagOnlySelector);
} }
if (!element) { if (!element) {
@@ -667,7 +794,7 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
} }
} }
} else { } else {
element = queryShadowDOM(currentRow, selector); element = queryElement(currentRow, selector);
} }
if (element) { if (element) {
@@ -683,7 +810,7 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
} }
} }
// Non-table data scraping remains unchanged // Process non-table data with both contexts support
for (let containerIndex = 0; containerIndex < containers.length; containerIndex++) { for (let containerIndex = 0; containerIndex < containers.length; containerIndex++) {
if (nonTableData.length >= limit) break; if (nonTableData.length >= limit) break;
@@ -694,8 +821,9 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
const record = {}; const record = {};
for (const [label, { selector, attribute }] of Object.entries(nonTableFields)) { for (const [label, { selector, attribute }] of Object.entries(nonTableFields)) {
const relativeSelector = selector.split('>>').slice(-1)[0]; // Get the last part of the selector after any context delimiter
const element = queryShadowDOM(container, relativeSelector); const relativeSelector = selector.split(/(?:>>|:>>)/).slice(-1)[0];
const element = queryElement(container, relativeSelector);
if (element) { if (element) {
record[label] = extractValue(element, attribute); record[label] = extractValue(element, attribute);

View File

@@ -680,11 +680,25 @@ export default class Interpreter extends EventEmitter {
return workflow; return workflow;
} }
private removeSpecialSelectors(workflow: Workflow) {
for (let actionId = workflow.length - 1; actionId >= 0; actionId--) {
const step = workflow[actionId];
if (step.where && Array.isArray(step.where.selectors)) {
// Filter out if selector has EITHER ":>>" OR ">>"
step.where.selectors = step.where.selectors.filter(selector =>
!(selector.includes(':>>') || selector.includes('>>'))
);
}
}
return workflow;
}
private async runLoop(p: Page, workflow: Workflow) { private async runLoop(p: Page, workflow: Workflow) {
let workflowCopy: Workflow = JSON.parse(JSON.stringify(workflow)); let workflowCopy: Workflow = JSON.parse(JSON.stringify(workflow));
// remove shadow selectors workflowCopy = this.removeSpecialSelectors(workflowCopy);
workflowCopy = this.removeShadowSelectors(workflowCopy);
// apply ad-blocker to the current page // apply ad-blocker to the current page
try { try {

View File

@@ -129,6 +129,12 @@ export interface BaseActionInfo {
hasOnlyText: boolean; hasOnlyText: boolean;
} }
interface IframeSelector {
full: string;
isIframe: boolean;
}
interface ShadowSelector { interface ShadowSelector {
full: string; full: string;
mode: string; mode: string;
@@ -148,6 +154,7 @@ export interface Selectors {
hrefSelector: string|null; hrefSelector: string|null;
accessibilitySelector: string|null; accessibilitySelector: string|null;
formSelector: string|null; formSelector: string|null;
iframeSelector: IframeSelector|null;
shadowSelector: ShadowSelector|null; shadowSelector: ShadowSelector|null;
} }

File diff suppressed because it is too large Load Diff

View File

@@ -13,6 +13,10 @@ export const getBestSelectorForAction = (action: Action) => {
case ActionType.DragAndDrop: { case ActionType.DragAndDrop: {
const selectors = action.selectors; const selectors = action.selectors;
if (selectors?.iframeSelector?.full) {
return selectors.iframeSelector.full;
if (selectors?.shadowSelector?.full) { if (selectors?.shadowSelector?.full) {
return selectors.shadowSelector.full; return selectors.shadowSelector.full;
} }

View File

@@ -12,6 +12,7 @@ import { useTranslation } from 'react-i18next';
interface ElementInfo { interface ElementInfo {
tagName: string; tagName: string;
hasOnlyText?: boolean; hasOnlyText?: boolean;
isIframeContent?: boolean;
isShadowRoot?: boolean; isShadowRoot?: boolean;
innerText?: string; innerText?: string;
url?: string; url?: string;
@@ -117,24 +118,47 @@ export const BrowserWindow = () => {
}, [screenShot, canvasRef, socket, screencastHandler]); }, [screenShot, canvasRef, socket, screencastHandler]);
const highlighterHandler = useCallback((data: { rect: DOMRect, selector: string, elementInfo: ElementInfo | null, childSelectors?: string[] }) => { const highlighterHandler = useCallback((data: { rect: DOMRect, selector: string, elementInfo: ElementInfo | null, childSelectors?: string[] }) => {
console.log("LIST SELECTOR", listSelector);
console.log("DATA SELECTOR", data.selector);
console.log("CHILD SELECTORS", data.childSelectors);
if (getList === true) { if (getList === true) {
if (listSelector) { if (listSelector) {
socket?.emit('listSelector', { selector: listSelector }); socket?.emit('listSelector', { selector: listSelector });
const hasValidChildSelectors = Array.isArray(data.childSelectors) && data.childSelectors.length > 0; const hasValidChildSelectors = Array.isArray(data.childSelectors) && data.childSelectors.length > 0;
if (limitMode) { if (limitMode) {
setHighlighterData(null); setHighlighterData(null);
} else if (paginationMode) { } else if (paginationMode) {
// only set highlighterData if type is not empty, 'none', 'scrollDown', or 'scrollUp' // Only set highlighterData if type is not empty, 'none', 'scrollDown', or 'scrollUp'
if (paginationType !== '' && !['none', 'scrollDown', 'scrollUp'].includes(paginationType)) { if (paginationType !== '' && !['none', 'scrollDown', 'scrollUp'].includes(paginationType)) {
setHighlighterData(data); setHighlighterData(data);
} else { } else {
setHighlighterData(null); setHighlighterData(null);
} }
} else if (data.childSelectors && data.childSelectors.includes(data.selector)) { } else if (data.childSelectors && data.childSelectors.includes(data.selector)) {
// highlight only valid child elements within the listSelector // Highlight only valid child elements within the listSelector
setHighlighterData(data); setHighlighterData(data);
} else if (data.elementInfo?.isIframeContent && data.childSelectors) {
// Handle pure iframe elements - similar to previous shadow DOM logic but using iframe syntax
// Check if the selector matches any iframe child selectors
const isIframeChild = data.childSelectors.some(childSelector =>
data.selector.includes(':>>') && // Iframe uses :>> for traversal
childSelector.split(':>>').some(part =>
data.selector.includes(part.trim())
)
);
setHighlighterData(isIframeChild ? data : null);
} else if (data.selector.includes(':>>') && hasValidChildSelectors) {
// Handle mixed DOM cases with iframes
// Split the selector into parts and check each against child selectors
const selectorParts = data.selector.split(':>>').map(part => part.trim());
const isValidMixedSelector = selectorParts.some(part =>
// We know data.childSelectors is defined due to hasValidChildSelectors check
data.childSelectors!.some(childSelector =>
childSelector.includes(part)
)
);
setHighlighterData(isValidMixedSelector ? data : null);
} else if (data.elementInfo?.isShadowRoot && data.childSelectors) { } else if (data.elementInfo?.isShadowRoot && data.childSelectors) {
// New case: Handle pure Shadow DOM elements // New case: Handle pure Shadow DOM elements
// Check if the selector matches any shadow root child selectors // Check if the selector matches any shadow root child selectors
@@ -156,17 +180,16 @@ export const BrowserWindow = () => {
) )
); );
setHighlighterData(isValidMixedSelector ? data : null); setHighlighterData(isValidMixedSelector ? data : null);
} } else {
else {
// if !valid child in normal mode, clear the highlighter // if !valid child in normal mode, clear the highlighter
setHighlighterData(null); setHighlighterData(null);
} }
} else { } else {
// set highlighterData for the initial listSelector selection // Set highlighterData for the initial listSelector selection
setHighlighterData(data); setHighlighterData(data);
} }
} else { } else {
// for non-list steps // For non-list steps
setHighlighterData(data); setHighlighterData(data);
} }
}, [highlighterData, getList, socket, listSelector, paginationMode, paginationType, captureStage]); }, [highlighterData, getList, socket, listSelector, paginationMode, paginationType, captureStage]);