vodorod/Dorod-Sky
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix overflow of default value in parameters (#1156)

Browse Source
This commit is contained in:
Shuchang Zheng
2024-11-07 07:22:24 -08:00
committed by GitHub
parent 61d1c24ffc
commit 2252148c5a
2 changed files with 492 additions and 474 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterAddPanel.tsx
View File

@@ -18,6 +18,7 @@ import { Checkbox } from "@/components/ui/checkbox";
import { getDefaultValueForParameterType } from "../workflowEditorUtils"; import { getDefaultValueForParameterType } from "../workflowEditorUtils";
import { toast } from "@/components/ui/use-toast"; import { toast } from "@/components/ui/use-toast";
import { SourceParameterKeySelector } from "../../components/SourceParameterKeySelector"; import { SourceParameterKeySelector } from "../../components/SourceParameterKeySelector";
import { ScrollArea, ScrollAreaViewport } from "@/components/ui/scroll-area";
type Props = { type Props = {
type: "workflow" | "credential" | "context" | "secret"; type: "workflow" | "credential" | "context" | "secret";
@@ -69,7 +70,9 @@ function WorkflowParameterAddPanel({ type, onClose, onSave }: Props) {
const [identityFields, setIdentityFields] = useState(""); const [identityFields, setIdentityFields] = useState("");
return ( return (
<div className="space-y-4"> <ScrollArea>
<ScrollAreaViewport className="max-h-[500px]">
<div className="space-y-4 p-1">
<header className="flex items-center justify-between"> <header className="flex items-center justify-between">
<span>{header(type)}</span> <span>{header(type)}</span>
<Cross2Icon className="h-6 w-6 cursor-pointer" onClick={onClose} /> <Cross2Icon className="h-6 w-6 cursor-pointer" onClick={onClose} />
@@ -174,7 +177,9 @@ function WorkflowParameterAddPanel({ type, onClose, onSave }: Props) {
{type === "credential" && ( {type === "credential" && (
<> <>
<div className="space-y-1"> <div className="space-y-1">
<Label className="text-xs text-slate-300">URL Parameter Key</Label> <Label className="text-xs text-slate-300">
URL Parameter Key
</Label>
<Input <Input
value={urlParameterKey} value={urlParameterKey}
onChange={(e) => setUrlParameterKey(e.target.value)} onChange={(e) => setUrlParameterKey(e.target.value)}
@@ -208,7 +213,9 @@ function WorkflowParameterAddPanel({ type, onClose, onSave }: Props) {
/> />
</div> </div>
<div className="space-y-1"> <div className="space-y-1">
<Label className="text-xs text-slate-300">Identity Fields</Label> <Label className="text-xs text-slate-300">
Identity Fields
</Label>
<Input <Input
value={identityFields} value={identityFields}
onChange={(e) => setIdentityFields(e.target.value)} onChange={(e) => setIdentityFields(e.target.value)}
@@ -317,6 +324,8 @@ function WorkflowParameterAddPanel({ type, onClose, onSave }: Props) {
</Button> </Button>
</div> </div>
</div> </div>
</ScrollAreaViewport>
</ScrollArea>
); );
} }

15
skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterEditPanel.tsx
View File

@@ -18,6 +18,7 @@ import { getDefaultValueForParameterType } from "../workflowEditorUtils";
import { WorkflowParameterInput } from "../../WorkflowParameterInput"; import { WorkflowParameterInput } from "../../WorkflowParameterInput";
import { toast } from "@/components/ui/use-toast"; import { toast } from "@/components/ui/use-toast";
import { SourceParameterKeySelector } from "../../components/SourceParameterKeySelector"; import { SourceParameterKeySelector } from "../../components/SourceParameterKeySelector";
import { ScrollArea, ScrollAreaViewport } from "@/components/ui/scroll-area";
type Props = { type Props = {
type: "workflow" | "credential" | "context" | "secret"; type: "workflow" | "credential" | "context" | "secret";
@@ -110,7 +111,9 @@ function WorkflowParameterEditPanel({
); );
return ( return (
<div className="space-y-4"> <ScrollArea>
<ScrollAreaViewport className="max-h-[500px]">
<div className="space-y-4 p-1">
<header className="flex items-center justify-between"> <header className="flex items-center justify-between">
<span>{header(type)}</span> <span>{header(type)}</span>
<Cross2Icon className="h-6 w-6 cursor-pointer" onClick={onClose} /> <Cross2Icon className="h-6 w-6 cursor-pointer" onClick={onClose} />
@@ -215,7 +218,9 @@ function WorkflowParameterEditPanel({
{type === "credential" && ( {type === "credential" && (
<> <>
<div className="space-y-1"> <div className="space-y-1">
<Label className="text-xs text-slate-300">URL Parameter Key</Label> <Label className="text-xs text-slate-300">
URL Parameter Key
</Label>
<Input <Input
value={urlParameterKey} value={urlParameterKey}
onChange={(e) => setUrlParameterKey(e.target.value)} onChange={(e) => setUrlParameterKey(e.target.value)}
@@ -249,7 +254,9 @@ function WorkflowParameterEditPanel({
/> />
</div> </div>
<div className="space-y-1"> <div className="space-y-1">
<Label className="text-xs text-slate-300">Identity Fields</Label> <Label className="text-xs text-slate-300">
Identity Fields
</Label>
<Input <Input
value={identityFields} value={identityFields}
onChange={(e) => setIdentityFields(e.target.value)} onChange={(e) => setIdentityFields(e.target.value)}
@@ -358,6 +365,8 @@ function WorkflowParameterEditPanel({
</Button> </Button>
</div> </div>
</div> </div>
</ScrollAreaViewport>
</ScrollArea>
); );
} }